-
Notifications
You must be signed in to change notification settings - Fork 262
Documentation and blog announcement for EnvVarMappings resource option #17452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Documentation ReviewThis blog post draft announces a new environment variable remapping feature for providers. Here are my findings: Critical Issues1. Incomplete code example (line 55) Python: provider = azure.Provider("my-provider",
env_var_mappings={
"ARM_CLIENT_SECRET": "MY_CUSTOM_SECRET_VAR",
})Main content goes here. Everything after the comment appears only on the full post page. Avoid using images or code samples in the first 70 words, as they may not render properly in summaries. For more guidance, see BLOGGING.md. Should be: export ARM_CLIENT_SECRET=12345675. Unclear feature description (line 52-53) 6. Heading capitalization (line 41)
7. Enhance the introduction Documentation Gap8. Missing supporting documentation
Meta Image VerificationThe PR includes a
Social Media FieldsThe frontmatter includes empty SummaryThis is a good start on announcing an exciting new feature! The main blockers are:
Once these are addressed, this will be ready for publication. Great work explaining a complex authentication scenario in an accessible way! Next steps: Mention @claude if you'd like help implementing any of these suggestions or creating the supporting documentation. |
|
Your site preview for commit 49444cc is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-17452-49444cc0.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit da95059 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-17452-da950591.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit daf80b6 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-17452-daf80b62.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit 3305a45 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-17452-3305a452.s3-website.us-west-2.amazonaws.com. |
Documentation ReviewI've reviewed the new envVarMappings resource option documentation and blog post. Overall, the content is well-structured and clearly explains the feature. Below are my findings: Issues FoundBlog Post (content/blog/new-provider-resource-option-environment-variable-remapping/index.md)
Documentation Page (content/docs/iac/concepts/resources/options/envvarmappings.md)
Index File Update (content/docs/iac/concepts/resources/options/_index.md)
Suggestions
SummaryThe documentation and blog post effectively explain the new envVarMappings feature. The primary issues are:
Once these issues are addressed, this will be ready to merge. Mention @claude if you'd like me to review the fixes or need additional assistance. |
|
Your site preview for commit 29d857a is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-17452-29d857af.s3-website.us-west-2.amazonaws.com. |
First outline of blog announcing environment variable remappings for providers